amend explanation of css file imports#1305
Merged
atilafassina merged 1 commit intosolidjs:mainfrom Oct 20, 2025
Merged
Conversation
Docs described styles imported into a component as being scoped to the component. This is not the current behavior. Imported styles become global without the use of CSS modules or other dependencies.
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atilafassina
approved these changes
Oct 20, 2025
Member
atilafassina
left a comment
atilafassina
left a comment
There was a problem hiding this comment.
True. the CSS is added per-route, but the classes aren't scoped.
Thanks!
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs describe styles from imported CSS Files as being scoped to the component. This is not the current behavior. Imported styles are added to the document head and are global.
Related issues & labels
Closes [Content]: Guide claims styles are scoped when imported #1282
Suggested label(s) (optional): documentation